Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#53 - forgot password page frontend #55

Merged
merged 16 commits into from
Aug 30, 2024
Merged

#53 - forgot password page frontend #55

merged 16 commits into from
Aug 30, 2024

Conversation

JokeUrSelf
Copy link
Collaborator

Added UI to this simple page

@JokeUrSelf JokeUrSelf linked an issue Aug 29, 2024 that may be closed by this pull request
Forgot password page, Frontend #53
Closed
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Missing screenshot in the pr description
  2. I don't like this input stretched on whole page. Why we cant just make some tile on the center of the screen with one field?

image

  1. I can click all the time the button "Zmień hasło" - maybe we should block it somehow? Or I don't know

  2. Reading the title of pr, I expected that also this page will have UI

image

@JokeUrSelf
Copy link
Collaborator Author

JokeUrSelf commented Aug 29, 2024 •
edited
Loading

  1. Missing screenshot in the pr description
  2. I don't like this input stretched on whole page. Why we cant just make some tile on the center of the screen with one field?

image

  1. I can click all the time the button "Zmień hasło" - maybe we should block it somehow? Or I don't know
  2. Reading the title of pr, I expected that also this page will have UI

image

  1. Will do
  2. Already fixed
  3. Do you want to block while the request is being processed, or for some range of time, like 60 seconds? The timer option will require changes to backend, feels complicated.
  4. Makes sense, will add.

AleksandraKozubal

This comment was marked as resolved.

Sign in to view

AleksandraKozubal

This comment was marked as resolved.

Sign in to view

@EwelinaSkrzypacz
Copy link
Member

Conflicts :(

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, we should have some link to back on the main page

image

@JokeUrSelf
Copy link
Collaborator Author

For me, we should have some link to back on the main page

image

That's gonna be in the header, Dominik works on that

EwelinaSkrzypacz
EwelinaSkrzypacz approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of this background, but we can change it later

@JokeUrSelf JokeUrSelf merged commit d600a31 into main Aug 30, 2024
2 checks passed
@JokeUrSelf JokeUrSelf deleted the 53-forgot-password-page-frontend branch August 30, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@kamilpiech97 kamilpiech97 kamilpiech97 approved these changes

@AleksandraKozubal AleksandraKozubal Awaiting requested review from AleksandraKozubal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forgot password page, Frontend
5 participants
@JokeUrSelf @EwelinaSkrzypacz @kamilpiech97 @AleksandraKozubal @tiankongldp